Skip to content

Conversation

@thedarkcolour
Copy link
Contributor

Closes #4661

This fixes the Personal access tokens list under Settings > Personal Access Tokens to display the PATs in order of creation, instead of being in a random order every page load.

@IMB11 IMB11 enabled auto-merge October 29, 2025 12:09
@Prospector
Copy link
Member

please run pnpm fix:frontend to fix the lint issues

@Prospector
Copy link
Member

oh actually, this is failing because the computed has a side effect because .sort() mutates the original array

@Prospector Prospector added website Relates to Modrinth.com web frontend frontend Involves work from the frontend team labels Oct 29, 2025
auto-merge was automatically disabled October 30, 2025 03:54

Head branch was pushed to by a user without write access

@IMB11 IMB11 requested a review from Prospector October 30, 2025 14:30
@Prospector Prospector enabled auto-merge October 30, 2025 19:20
@Prospector
Copy link
Member

now it's lint issues lol. pnpm fix:frontend

auto-merge was automatically disabled October 30, 2025 23:09

Head branch was pushed to by a user without write access

@thedarkcolour
Copy link
Contributor Author

FYI, I couldn't get that lint fix command to work due to errors with --filter in the command (I'm on Windows using pnpm)
I had to change it to this in order to test the linting locally: "fix:frontend": "turbo run fix --continue --parallel "

@Prospector
Copy link
Member

weird, it should work on windows just fine

@Prospector Prospector enabled auto-merge October 30, 2025 23:19
@Prospector Prospector added this pull request to the merge queue Oct 30, 2025
Merged via the queue into modrinth:main with commit 00f9cf0 Oct 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Involves work from the frontend team website Relates to Modrinth.com web frontend

Development

Successfully merging this pull request may close these issues.

PATs are displayed in random order on the PATs screen

3 participants